Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketClient: fix unexpected eof + improve subscribe & query #54

Merged
merged 1 commit into from
Nov 9, 2023
Merged

WebSocketClient: fix unexpected eof + improve subscribe & query #54

merged 1 commit into from
Nov 9, 2023

Conversation

Kiruse
Copy link
Contributor

@Kiruse Kiruse commented Oct 25, 2023

Fix an "unexpected EOF" when parsing empty message from host node in WebSocketClient. Further, add support for multiple subscriptions (previously only 1) and improve TendermintQuery usage with dedicated query builder.

emidev98
emidev98 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@emidev98 emidev98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Very good improvements! I encourage you to keep contributing in the future!

@emidev98 emidev98 merged commit 8e5b3e8 into terra-money:main Nov 9, 2023
@emidev98 emidev98 mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emidev98 emidev98 emidev98 approved these changes

@mwmerz mwmerz Awaiting requested review from mwmerz

@alecande11 alecande11 Awaiting requested review from alecande11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kiruse @emidev98