Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sdk version configs to gradle.properties #1685

Merged
2 commits merged into from
Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
move sdk version to project.properties
  • Loading branch information
cn00 committed Aug 4, 2020
commit 87d72cf14feb6c8214e5b106d53867d89bd8c7f7
8 changes: 4 additions & 4 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ plugins {
}

android {
compileSdkVersion 28
ndkVersion '21.3.6528147'
compileSdkVersion project.properties.compileSdkVersion.toInteger()
ndkVersion project.properties.ndkVersion

dependencies {
implementation "androidx.annotation:annotation:1.1.0"
Expand All @@ -15,8 +15,8 @@ android {

defaultConfig {
applicationId "com.termux"
minSdkVersion 24
targetSdkVersion 28
minSdkVersion project.properties.minSdkVersion.toInteger()
targetSdkVersion project.properties.targetSdkVersion.toInteger()
versionCode 96
versionName "0.96"

Expand Down
5 changes: 5 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@
# org.gradle.parallel=true
org.gradle.jvmargs=-Xmx2048M
android.useAndroidX=true

minSdkVersion=21
targetSdkVersion=29
This conversation was marked as resolved.
Show resolved Hide resolved
ndkVersion=21.3.6528147
compileSdkVersion=28
8 changes: 4 additions & 4 deletions terminal-emulator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ ext {
}

android {
compileSdkVersion 28
ndkVersion '21.3.6528147'
compileSdkVersion project.properties.compileSdkVersion.toInteger()
ndkVersion project.properties.ndkVersion

defaultConfig {
minSdkVersion 21
targetSdkVersion 28
minSdkVersion project.properties.minSdkVersion.toInteger()
targetSdkVersion project.properties.targetSdkVersion.toInteger()

externalNativeBuild {
ndkBuild {
Expand Down
6 changes: 3 additions & 3 deletions terminal-view/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@ ext {
}

android {
compileSdkVersion 28
compileSdkVersion project.properties.compileSdkVersion.toInteger()

dependencies {
implementation "androidx.annotation:annotation:1.1.0"
api project(":terminal-emulator")
}

defaultConfig {
minSdkVersion 21
targetSdkVersion 28
minSdkVersion project.properties.minSdkVersion.toInteger()
targetSdkVersion project.properties.targetSdkVersion.toInteger()
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}

Expand Down