SurfacePosition #51
Merged
SurfacePosition #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial attempt at implementing SurfacePosition. Algorithm is mostly shared with AirbornePosition, so the common elements are moved to the PositionUpdate class, which maintains a cache of even/odd frames, decides whether Global or Local calculation can be used, and generally contains the complexity of the CPR system. Some further sanity checks are required, and also a way to choose between multiple possible solutions for lat/lon for Surface data.
Douglasdc3
commented
Mar 11, 2023
|
|
||
| public void validateSurface() { | ||
| // For SurfacePositions we get 8 possible solutions: 2x latitude, 4x longitude zones at 90 degree increments | ||
| // TODO Could use receiver/reference lat/lon to chose which possibile solution is closest... or build-up an average over data received to-date |
There was a problem hiding this comment.
Closest to the reference point for the first decoding then for the second decoding the reference point should change to the previous position. This will be I think the most complete solution
Revised SurfacePosition decoding to pick the lat/lon quadrant closest to the current active position. This initialises at the receiver lat/lon argument (if supplied), and updates a rolling-average with each global position update (this may not be strictly necessary... may revise later to just use the first N updates received).
|
Small changes were made mainly pre calculating the track and velocity information. Then uses the pre-calculated values to assign them to the track object when available |
…Local position updates, both Airborne and Surface.
|
SurfacePositionUpdates should now be working correctly, and AirbornePositionUpdates now correctly work for both Global and Local updates. Tests have been provided, but may not cover all edge-cases. |
|
Looking good @IDBeswick thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started by @IDBeswick
Initial attempt at implementing SurfacePosition. Algorithm is mostly shared with AirbornePosition, so the common elements are moved to the PositionUpdate class, which maintains a cache of even/odd frames, decides whether Global or Local calculation can be used, and generally contains the complexity of the CPR system. Some further sanity checks are required, and also a way to choose between multiple possible solutions for lat/lon for Surface data.