Add equality tests #141
Merged
Add equality tests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test classes and methods public fix method reference in equals method, apply spotless fix missing fields in equals methods, cleanup methods and use equalsverifier library for tests test bloomTermId in ConditionConfigTest add ConditionConfigTest apply spotless add hash code override methods where equals method is overwritten
kortemik
approved these changes
Dec 12, 2024
|
good work, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds equality tests originally developed to PR #100 . Equals and hashcode methods were overridden in a previous merged PR so the code for the equals and hashcode methods weren't needed anymore from #100.
There were issues in a few objects that were caught by equalsVerifier, fixed those.