Fixed issue #125: Components failed within the table. #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'visibleComponents' is not set by Table constructor
- Filter components will break, if filter bar is not visible during table initialization. - Still getting connector errors in client side console
|
I came across this issue with @PreserveOnRefresh annotated UI; when FilterTable had Label component it's text content disappeared when browser was refreshed, This also seemed to cause an issue with TestBench; it seems that when using v8 version of FilterTable TestBench queries are unable to locate any components inside FilterTable: e.g. I compiled addon from lordmikefin's branch and this seemed to fix both of my issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created issue #125 earlier in this month.
I debugged the code and here is my solution :)