Skip to content

Merge deploy user to apps #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Merge deploy user to apps #6

wants to merge 1 commit into from

Conversation

hzmangel
Copy link

Currently the user for deployment is deploy, while for running application is apps. This devision may cause permission problems, such as the one described in issue #5. The user deploy only works on deployment of webapps, so I think they can be merged to one account apps.

@andrewhavens
Copy link

Anything stopping this from getting merged?

@arrtchiu
Copy link

arrtchiu commented Feb 5, 2014

The code in this PR gives the apps user full sudoer access with no password. I think from a "secure by default" point of view this shouldn't be merged since a minor RCE bug in a web app can trivially be escalated to full root access.

Instead of running rake tasks as the deploy user, why not use sudo to impersonate the apps user? sudo -u apps RAILS_ENV=production bin/rake my:task

@thekindofme
Copy link

Agree with @arrtchiu on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants