Changing tensor creation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajakovljevicTT
requested review from
kmitrovicTT and
mrakitaTT
as code owners
|
||||||||||||||
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 77.82% 78.02% +0.20%
==========================================
Files 21 21
Lines 1028 1042 +14
==========================================
+ Hits 800 813 +13
- Misses 228 229 +1 ☔ View full report in Codecov by Sentry. |
umalesTT
approved these changes
Feb 3, 2025
umalesTT
reviewed
Feb 3, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/tensor_changing_creation
branch
3 times, most recently
from
327ef63 to
b847be0
Compare
kmitrovicTT
reviewed
Feb 6, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/tensor_changing_creation
branch
from
b847be0 to
ecd2350
Compare
mrakitaTT
reviewed
Feb 6, 2025
ajakovljevicTT
force-pushed
the
ajakovljevic/tensor_changing_creation
branch
2 times, most recently
from
0e27ca6 to
20ff4d5
Compare
ajakovljevicTT
force-pushed
the
ajakovljevic/tensor_changing_creation
branch
from
20ff4d5 to
ed35338
Compare
mrakitaTT
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Fixes #202
Fixes #200
Problem description
Since we were given raw pointers to make tensors for in PJRT, we had no control over their ownership. This PR allocates new memory and copies the contents of the pointer, so now PJRT has full control of its memory.