Install maturin as part of pyenv since it's needed to build #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olof Johansson <olofj@tenstorrent.com>
|
@warthog9 is this the Makefile that you deleted in your packaging branch? |
|
It is tracked as a dependency of the crate, where it's actually used: https://github.com/tenstorrent/luwen/blob/main/crates/pyluwen/pyproject.toml And yes @TTDRosen that makefile is deleted in the packaging branch as it causes a lot of packaging problems having a makefile the way that makefile was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maturin isn't tracked as a dependency anywhere, but it's needed to build. Luckily we can just pip install it when we setup the pyenv in the first place.