Added download utility function : maybe_download_and_extract() #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onally extracting .zip or .tar files
|
@JoelKronander could we simplify the args of function ? e.g. use |
|
Just updated a new version with an optional extract=True/False option. If set to True, detects if .tar or .zip files and uncompresses. |
JoelKronander
changed the title
…onally extracting .zip or .tar files Minor fixes Updated VGG16 tutorial to automatically download files changed interface to extract=True/False and automatic detect if .zip or .tar file added return value as filepath
|
Is something like this interface what you had in mind? Or should I change it to something else? |
|
I've adding the path argument to the load dataset functions. I think you can replace the origin download and extract function with your maybe_download_and_extract() function. |
|
superceded by PR#72 |
JoelKronander
deleted the
download_utility_and_file_downloading_clean_up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a download utility function in files.py, maybe_download_and_extract, that tries to find filename in working_dir otherwise downloads with progress bar and optionally extracts .tar and .zip files.
Also updated the tutorial_vgg16 example to use the new function.
Several dataset loaders in files could also adapt the new function for improved consistency.