lint fixed #240

vulkomilev · 2023-04-25T17:54:44Z

Fixes #16

It's a good idea to open an issue first for discussion.

[ X] Tests pass
Appropriate changes to README are included in PR

review-notebook-app · 2023-04-25T17:54:48Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2023-04-25T17:55:00Z

Thanks for the PR! 🚀

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

hanneshapke · 2023-04-25T17:57:48Z

@vulkomilev Thank you for the new PR!
pylint and isort are green. Looks like yapf complains about the indentation level in this file examples/filter_component/filter_function.py. Maybe you can update the file manually.

rcrowe-google

Getting close! Could you:

Remove examples/filter_component/tfx-addons
Rename examples/filter_component to examples/example_filter
Remove tfx_addons/example_filter/data (including test_data.csv)

Thanks!

rcrowe-google · 2023-05-11T16:28:14Z

Wait, sorry do not remove tfx_addons/example_filter/data (including test_data.csv). We need it for the tests!

vulkomilev · 2023-05-11T18:34:28Z

okay На чт, 11.05.2023 г. в 19:28 ч. Robert Crowe ***@***.***> написа:

…

Wait, sorry *do not remove tfx_addons/example_filter/data (including test_data.csv)*. We need it for the tests! — Reply to this email directly, view it on GitHub <#240 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATA3WEK3JF7QBNXEN5CX6G3XFUHSRANCNFSM6AAAAAAXLK4QBQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rcrowe-google

Please revert this change. The only data which should be included is the CSV file

vulkomilev · 2023-05-15T17:48:14Z

okaay На пн, 15.05.2023 г. в 20:47 ч. Robert Crowe ***@***.***> написа:

…

***@***.**** commented on this pull request. Please revert this change. The only data which should be included is the CSV file — Reply to this email directly, view it on GitHub <#240 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATA3WEJJOOBRVK564ASCCLTXGJT3FANCNFSM6AAAAAAXLK4QBQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

vulkomilev · 2023-05-15T17:52:40Z

done На пн, 15.05.2023 г. в 20:47 ч. Valko Milev < ***@***.***> написа:

…

okaay На пн, 15.05.2023 г. в 20:47 ч. Robert Crowe ***@***.***> написа: > ***@***.**** commented on this pull request. > > Please revert this change. The only data which should be included is the > CSV file > > — > Reply to this email directly, view it on GitHub > <#240 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATA3WEJJOOBRVK564ASCCLTXGJT3FANCNFSM6AAAAAAXLK4QBQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

rcrowe-google

Please rename examples/filter_component to examples/example_filter so that it matches the name of the component.

rcrowe-google

Thanks!

examples/example_filter/filter_function.py

tfx_addons/example_filter/component.py

tfx_addons/example_filter/executor_test.py

tfx_addons/example_filter/filter_function.py

hanneshapke

Hi Valko,
I left a few questions and comment on the PR. Feel free to reply in the thread if you have questions.

vulkomilev · 2023-05-20T12:44:49Z

done

hanneshapke · 2023-05-20T17:27:11Z

tfx_addons/example_filter/executor_test.py

-from tfx.utils import test_case_utils
-
-
-def _create_pipeline(


Just out of curiosity: Why did you remove the test?

I recalled that I have copied the test from another component without giving it much of a thought .

hanneshapke · 2023-05-20T17:28:10Z

tfx_addons/example_filter/filter_function.py

@@ -26,6 +12,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 # ==============================================================================
+"""Filters the data from input data by using the filter function.
+
+Args:


move the args + returns into the function doc string, and describe the module in the doc string at the top of the file.

Tiny last change

Still pending

I think I have fixed it

hanneshapke · 2023-06-29T01:35:39Z

tfx_addons/example_filter/data/test_data.csv

@@ -0,0 +1,51 @@
+label,col1


~~Help me understand why? Couldn't you link to the same file?~~
Sorry, ignore. Got it.

hanneshapke · 2023-07-02T04:07:33Z

@vulkomilev Heads up. The linter is failing. Check out https://github.com/tensorflow/tfx-addons/actions/runs/5432854616/jobs/9880173830?pr=240

vulkomilev · 2023-07-02T07:38:22Z

done I have fixed it

hanneshapke · 2023-07-02T15:17:49Z

/lgtm

lint fixed

cc5b622

vulkomilev requested review from rcrowe-google and theadactyl as code owners April 25, 2023 17:54

github-actions bot added the needs-lgtm label Apr 25, 2023

rcrowe-google requested review from hanneshapke and removed request for theadactyl April 25, 2023 18:39

vulkomilev added 2 commits April 26, 2023 18:05

lint fix

4c6638b

removed binary file

90eca13

rcrowe-google reviewed May 11, 2023

View reviewed changes

files for example data are restored

129e89c

rcrowe-google reviewed May 15, 2023

View reviewed changes

removed some file

8a0cfbe

rcrowe-google reviewed May 15, 2023

View reviewed changes

renamed filter_component

5195772

rcrowe-google approved these changes May 18, 2023

View reviewed changes

hanneshapke suggested changes May 20, 2023

View reviewed changes

vulkomilev added 2 commits May 20, 2023 15:44

some fixes

e8bc751

some fixes

eb7e4c3

hanneshapke reviewed May 20, 2023

View reviewed changes

vulkomilev added 2 commits June 29, 2023 18:43

some lint fixes

395c6ad

some lint fixes

714dcc7

vulkomilev requested a review from hanneshapke June 29, 2023 16:08

hanneshapke suggested changes Jun 29, 2023

View reviewed changes

fixed some comments

5e47b29

fixed some formating

2b24eff

hanneshapke approved these changes Jul 2, 2023

View reviewed changes

hanneshapke merged commit 8a276a7 into tensorflow:main Jul 4, 2023

lint fixed #240

lint fixed #240

Uh oh!

Conversation

vulkomilev commented Apr 25, 2023

Uh oh!

review-notebook-app bot commented Apr 25, 2023

Uh oh!

github-actions bot commented Apr 25, 2023

Uh oh!

hanneshapke commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rcrowe-google left a comment

Choose a reason for hiding this comment

Uh oh!

rcrowe-google commented May 11, 2023

Uh oh!

vulkomilev commented May 11, 2023 via email

Uh oh!

rcrowe-google left a comment

Choose a reason for hiding this comment

Uh oh!

vulkomilev commented May 15, 2023 via email

Uh oh!

vulkomilev commented May 15, 2023 via email

Uh oh!

rcrowe-google left a comment

Choose a reason for hiding this comment

Uh oh!

rcrowe-google left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanneshapke left a comment

Choose a reason for hiding this comment

Uh oh!

vulkomilev commented May 20, 2023

Uh oh!

hanneshapke May 20, 2023

Choose a reason for hiding this comment

Uh oh!

vulkomilev May 22, 2023

Choose a reason for hiding this comment

Uh oh!

hanneshapke May 20, 2023

Choose a reason for hiding this comment

Uh oh!

hanneshapke May 20, 2023

Choose a reason for hiding this comment

Uh oh!

hanneshapke Jun 29, 2023

Choose a reason for hiding this comment

Uh oh!

vulkomilev Jul 1, 2023

Choose a reason for hiding this comment

Uh oh!

hanneshapke Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hanneshapke commented Jul 2, 2023

Uh oh!

vulkomilev commented Jul 2, 2023

Uh oh!

hanneshapke commented Jul 2, 2023

Uh oh!

Uh oh!

hanneshapke commented Apr 25, 2023 •

edited

Loading

hanneshapke Jun 29, 2023 •

edited

Loading