Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Make setWasmPaths require an entry for each WASM binary. #3749

Merged
merged 4 commits into from
Aug 10, 2020
Merged

[wasm] Make setWasmPaths require an entry for each WASM binary. #3749

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79d32a6
fix
annxingyuan Aug 7, 2020
a4f2b00
fix
annxingyuan Aug 7, 2020
32b1826
Merge branch 'master' into setwasmpaths
annxingyuan Aug 7, 2020
cba29db
Merge branch 'master' into setwasmpaths
annxingyuan Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@annxingyuan
annxingyuan committed Aug 7, 2020
commit a4f2b009203453551b11dafe9e7a72bcffe329a6
2 changes: 1 addition & 1 deletion tfjs-backend-wasm/src/backend_wasm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export function setWasmPaths(
wasmFileMap = prefixOrFileMap;
const missingPaths =
wasmBinaryNames.filter(name => wasmFileMap[name] == null);
if (missingPaths.length) {
if (missingPaths.length > 0) {
throw new Error(
`There were no entries found for the following binaries: ` +
`${missingPaths.join(',')}. Please either call setWasmPaths with a ` +
Expand Down