This repository was archived by the owner on Sep 17, 2022. It is now read-only.
Better build fixes for libtensorflow on all 3 platforms #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangyizhang
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
LGTM. FYI it works with node-pre-gyp to separately downloading binary and tfjs_binding.node
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @kangyizhang)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got staging removed for all platforms except Windows. Windows hosted tensorflow binaries now include the .lib file so we don't have to generate that.
Ideally, we can figure out how to hack the node-gyp config to make this work - let's track that issue here: tensorflow/tfjs#1696
This change is