Skip to content

Add live accuracy chart to baseball demo #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2018
Merged

Add live accuracy chart to baseball demo #68

merged 2 commits into from
May 6, 2018

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented May 6, 2018 •
edited
Loading

Also:

  • Remove bootstrap, jquery and popper.js to reduce external deps
  • Rename download-training-data to download-data
  • Move few dev deps to deps
  • Make the socket reply more frequent when socket is disconnected

This change is Reviewable

@dsmilkov dsmilkov requested a review from nkreeger May 6, 2018 04:06
@dsmilkov dsmilkov changed the title Add live accuracy chart Add live accuracy chart to baseball demo May 6, 2018
@nkreeger
Copy link
Contributor

nkreeger commented May 6, 2018

:lgtm_strong:

Review status: 0 of 14 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@dsmilkov dsmilkov merged commit 7306f96 into master May 6, 2018
@dsmilkov dsmilkov deleted the baseball-chart branch May 6, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkreeger nkreeger Awaiting requested review from nkreeger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmilkov @nkreeger