Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Conversation

@nkreeger
Copy link
Contributor

@nkreeger nkreeger commented Jun 24, 2019

This helps for platforms using the WebGL env without actually having a
DOM canvas to use. Offscreen usage will fail on unit tests without this
check on this.canvas.

To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.


This change is Reviewable

This helps for platforms using the WebGL env without actually having a
DOM canvas to use. Offscreen usage will fail on unit tests without this
check on this.canvas.
@nkreeger nkreeger requested a review from nsthorat June 24, 2019 21:19
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat)

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkreeger)


src/backends/webgl/backend_webgl.ts, line 2489 at r1 (raw file):

    }
    this.textureManager.dispose();
    if (this.canvas !== null && this.canvas.remove !== null) {

single != here to catch undefined (for both of them)

I think that's why the tests are failing

@nkreeger nkreeger merged commit 60b62e8 into master Jun 24, 2019
@nkreeger nkreeger deleted the kreeger/canvas-fix branch June 24, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants