This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Add tf.io.http and deprecate tf.io.browserHTTPRequest #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Apr 18, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @caisq and @dsmilkov)
nsthorat
changed the title
nsthorat
pushed a commit
to tensorflow/tfjs-node
that referenced
this pull request
Apr 19, 2019
INTERNAL - Update to 1.1 - Remove registering a node io http handler. This is handled entirely by core now. I'll deprecate nodeHTTPRequest when tensorflow/tfjs-core#1684 lands.
caisq
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
Reviewable status:
src/io/http.ts, line 244 at r2 (raw file):
http
nit: http -> http
nsthorat
commented
Apr 22, 2019
There was a problem hiding this comment.
Reviewable status:
src/io/http.ts, line 244 at r2 (raw file):
Previously, caisq (Shanqing Cai) wrote…
httpnit: http ->
http
Done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.io.httpsupports node and the browser as well as overriding the global fetch and using it.Node will use this registry instead of registering its own.
This change is