Use vector constructor to initialize Array3D. #8144
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current constructor of Array3D calls resize to initialize the inner vector of Array3D and follows up with a Fill call. This can be replaced with a simple call to vector constructor. Vector constructor might also be more efficient.
|
Can one of the admins verify this patch? |
hawkinsp
reviewed
Mar 6, 2017
Using vector ctor.
|
@hawkinsp Added Array4D changes. |
hawkinsp
approved these changes
Mar 7, 2017
|
@tensorflow-jenkins Test this please |
|
The XLA test looks like a flake - retriggering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current constructor of Array3D calls resize to initialize the inner vector of
Array3D and follows up with a Fill call. This can be replaced with a simple
call to vector constructor. Vector constructor might also be more efficient.