Fixes sync errors #6739
Merged
Fixes sync errors #6739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
Jan 31, 2024
Contributor
rileyajones
left a comment
rileyajones
left a comment
There was a problem hiding this comment.
The internal lint rules are different from the external ones and there are examples of them being mutually incompatible so we typically assume the sync will not pass lint and will merge it anyway.
Member
Author
Thanks for the context, it's good to know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Recently merged hparam column PRs (#6732, #6733, #6736) will cause build and lint errors during 1p sync.
Technical description of changes
DataTableUtils->dataTableUtils