-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displays hparams in scalar card tables #6737
Merged
Merged
Changes from 32 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
89fc04a
Adds shared hparam related common selectors
hoonji bed9604
Fixes test description
hoonji 9eef734
Fixes formatting
hoonji f72b2a2
Changes reorder column events to use source and destination
hoonji f3130d0
Fixes lint
hoonji a9c53c3
Runs buildifier
hoonji f17fe22
Turns groupColumns into a projector function helper
hoonji 555a84e
Merge branch 'hparam_common_selectors' into hparam_update_reorder
hoonji 6e45e6e
Makes runs table use hparam store for hparam columns
hoonji ec93a93
Changes ColumnGroup to enum
hoonji cff6ce3
Merge branch 'hparam_common_selectors' into hparam_update_reorder
hoonji c17894d
Applies comments
hoonji 694251c
Merge branch 'hparam_update_reorder' into hparam_runs_hparams
hoonji ff8c096
Applies comments
hoonji 999bffc
Adds hparams to scalar tables
hoonji d3f2cb9
Fixes card view stacking context
hoonji 62f4099
Applies fixes
hoonji e96b32a
Fixes lint error
hoonji 7f39b54
Fixes lint error
hoonji ef301e5
Merge branch 'hparam_update_reorder' into hparam_runs_hparams
hoonji 06b550e
Merge branch 'hparam_runs_hparams' into hparam_scalar_table_hparams
hoonji dd390f0
Revert card view layout paint
hoonji 8f95404
Move contain layout paint to original position
hoonji c58c14d
Applies fixes
hoonji 90d7125
Applies fixes
hoonji 3dcdefb
Remove unused dataTableColumnAdded action
hoonji 4d7c07a
Adds remove column functionality to scalar tables
hoonji 2a7bb5c
Merge branch 'master' into hparam_scalar_table_hparams
hoonji 2e07ef8
Misc fixes
hoonji e29efc3
Removes hidable contxt menu option and combines it with removable
hoonji 129b298
Merge branch 'hparam_remove_hidable' into hparam_scalar_table_hparams
hoonji 0428494
Removes hide column functionality from data tables
hoonji 1a1f08b
Adds enableScalarColumnContextMenus feature flag
hoonji 85fa49a
Reverts merge error
hoonji 3dfae7c
Merge branch 'hparam_add_feature_Flag' into hparam_scalar_table_hparams
hoonji a8a1b5a
Fixes lint
hoonji 9585fb2
Merge branch 'master' into hparam_scalar_table_hparams
hoonji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suppresses 1p tslint