Skip to content

Conversation

@hoonji
Copy link
Member

@hoonji hoonji commented Jan 22, 2024

Motivation for features / changes

Before enabling context menus for scalar card tables, it will be useful to explicitly distinguish the two different removal related column interactions that are currently available: "remove" and "hide". "Removed" columns must be re-added to display again (this is what's currently done for hparams in the runs table). "Hidden" columns can be re-enabled via the "edit table columns" (this is only available in scalar tables).

Distinguishing these two operations also provides an easy way to provide similar but different hparam columns for the runs and scalar tables: first add the hparams that you need to both tables, then hide the ones you don't need in the scalar tables.

Technical description of changes

  • adds a hidable property to the ColumnHeader type.
  • properly initializes ColumnHeader context menu options in the runs and metrics reducers, and overrides any options set in localstorage. This will effectively turn context options into static, system-defined features.
  • disables movability and removability for RUN columns. This should have negligible impact on usability while allowing us to define useful column orderings such as | run | hparam_columns | other_columns |

Detailed steps to verify changes work correctly (as executed by you)

  • Unit tests pass

@hoonji hoonji requested a review from rileyajones January 22, 2024 06:32
@hoonji hoonji merged commit 189e0f8 into hparam_persistence Jan 24, 2024
@hoonji hoonji deleted the hparam_hidable branch January 24, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants