data: pass --samples-per-plugin unconditionally
#4790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In #4689, we decided to only pass `--samples-per-plugin` to the data server conditionally, because at the time the latest public release of the data server did not support that flag. Since then, v0.4.0 has been published, so we can pass the flag unconditionally. Test Plan: Verified that with latest `tb-nightly`’s dependencies, the server behaves as expected both with and without `--samples_per_plugin`. wchargin-branch: data-always-pass-samples wchargin-source: 04f7394f218d395db4366dceeed9b5dfb0d1dcef
psybuzz
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #4689, we decided to only pass
--samples-per-pluginto the dataserver conditionally, because at the time the latest public release of
the data server did not support that flag. Since then, v0.4.0 has been
published, so we can pass the flag unconditionally.
Test Plan:
Verified that with latest
tb-nightly’s dependencies, the serverbehaves as expected both with and without
--samples_per_plugin.wchargin-branch: data-always-pass-samples