rust: use bytes::Bytes for proto fields
#4677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This patch changes our proto bindings for `bytes` fields from `Vec<u8>` to [`Bytes`]. The advantage is that they can be shared and sliced cheaply. For example, the `ReadBlob` RPC no longer needs to clone the full contents of the blob to refer to it after dropping the read lock, and it also no longer needs to clone each sent chunk. Correspondingly, we now represent blob sequences as `Vec<Bytes>` (seems pretty sensible). Another option is `Vec<Arc<[u8]>>` here, but creating an `Arc<[u8]>` from a `Vec<u8>` or `Bytes` [requires a full copy]. This patch is made mostly by updating `gen_protos_tool` and pushing through the type changes. [`Bytes`]: https://docs.rs/bytes/1.0.1/bytes/struct.Bytes.html [requires a full copy]: https://stackoverflow.com/a/44641572 Test Plan: For most of these changes, type-checking is sufficient; for the changes to `ReadBlob`, unit tests are relevant, too. wchargin-branch: rust-bytes wchargin-source: 59248986d03702cb3e7dd66e8e69f4dcdf6a059f
wchargin
added
theme:performance
|
An alternate description of this change would be “avoid 2n bytes worth |
|
@psybuzz: Friendly ping? |
psybuzz
approved these changes
Feb 16, 2021
|
No problem; thanks! |
wchargin
added a commit
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch changes our proto bindings for
bytesfields fromVec<u8>to
Bytes. The advantage is that they can be shared and slicedcheaply. For example, the
ReadBlobRPC no longer needs to clone thefull contents of the blob to refer to it after dropping the read lock,
and it also no longer needs to clone each sent chunk.
Correspondingly, we now represent blob sequences as
Vec<Bytes>(seemspretty sensible). Another option is
Vec<Arc<[u8]>>here, but creatingan
Arc<[u8]>from aVec<u8>orBytesrequires a full copy.This patch is made mostly by updating
gen_protos_tooland pushingthrough the type changes.
Test Plan:
For most of these changes, type-checking is sufficient; for the changes
to
ReadBlob, unit tests are relevant, too.wchargin-branch: rust-bytes