Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder colors in the random order suggested by Paul Tol. #453

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

yingusxiaous
Copy link
Contributor

Reorder colors in the random order suggested by Paul Toh. #449

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@yingusxiaous
Copy link
Contributor Author

I signed it!

@wchargin
Copy link
Contributor

Please change the commit title to read "Paul Tol" (note spelling). Also, commit titles do not have a period at the end. (Reasoning and details here.) Besides that, this looks good to me; I can merge it once googlebot is happy.

@yingusxiaous yingusxiaous changed the title Reorder colors in the random order suggested by Paul Toh. Reorder colors in the random order suggested by Paul Tol. Aug 31, 2017
@googlebot
Copy link

CLAs look good, thanks!

@yingusxiaous
Copy link
Contributor Author

Changed commit message and PR title. Please take a look, thank you!

@wchargin wchargin merged commit 81c802c into tensorflow:master Aug 31, 2017
jart pushed a commit to jart/tensorboard that referenced this pull request Sep 6, 2017
jart pushed a commit that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants