Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalars: commit chart changes in batch #4053

Merged
merged 11 commits into from
Aug 20, 2020
Merged

scalars: commit chart changes in batch #4053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
065d7ca
data-loader-behavior: add fine-grained batching support
wchargin Aug 18, 2020
beff777
scalars: multiplex data fetches within a tag
wchargin Aug 18, 2020
f4ddbf7
[update diffbase]
wchargin Aug 19, 2020
50c7112
[update patch]
wchargin Aug 19, 2020
ef6d050
scalars: commit chart changes in batch
wchargin Aug 19, 2020
a80c564
[update patch]
wchargin Aug 19, 2020
02f6054
[update diffbase]
wchargin Aug 19, 2020
aaa17f9
[bump ci]
wchargin Aug 19, 2020
534702f
[update patch]
wchargin Aug 20, 2020
fa6f09f
[update diffbase]
wchargin Aug 20, 2020
f9905e1
[update diffbase]
wchargin Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorboard/components_polymer3/tf_line_chart_data_loader/tf-line-chart-data-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ class _TfLineChartDataLoader<ScalarMetadata>
_maybeRenderedInBadState: boolean = false;

onLoadFinish() {
this.commitChanges();
if (this.dataToLoad.length > 0 && this._resetDomainOnNextLoad) {
// (Don't unset _resetDomainOnNextLoad when we didn't
// load any runs: this has the effect that if all our
Expand Down
1 change: 0 additions & 1 deletion tensorboard/plugins/scalar/polymer3/tf_scalar_dashboard/tf-scalar-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ export class TfScalarCard extends PolymerElement {
const name = this._getSeriesNameFromDatum(item);
scalarChart.setSeriesMetadata(name, item);
scalarChart.setSeriesData(name, formattedData);
scalarChart.commitChanges();
};

@property({type: Object})
Expand Down