Updates list of TPU-compatible ops for the TB graph viewer. #4024
Conversation
|
Tayo, thanks for this. The team is in the midst of a complicated migration to Polymer 3 (#3887), which should finish soon. There will be some delay in getting to this PR. |
|
@manivaradarajan Sure, no hurry. |
| '_Retval', | ||
| '_TPUCompile', | ||
| '_TPUExecute', | ||
| '_SendTPUEmbeddingGradients', |
There was a problem hiding this comment.
nit: should _Send... should be alphabetcally sorted before L481?
| @@ -364,10 +471,17 @@ module tf.graph.op { | |||
| 'Switch', | |||
| // Ops below are inserted by the compiler. | |||
| '_Arg', | |||
| '_ArrayToList', | |||
| '_FusedBatchNormEx', | |||
| '_ListToArray', | |||
| '_ParallelConcatUpdate', | |||
There was a problem hiding this comment.
When running SupportedOpsMain from tensorflow/compiler/tf2xla/tf2xla_supported_ops.cc, I'm not seeing these ops
_ParallelConcatUpdate_TPUCompile_TPUExecute
in the list of results. Is keeping them in the allowlist intentional?
There was a problem hiding this comment.
Yes. The idea was to support 'legacy' existing graphs. Although this policy can be changed later.
|
The migration is done and we can now take in all the changes. Thanks for waiting. Please rebase and update your pull request :) |
stephanwlee
force-pushed
the
tpu_ops_update
branch
from
ae1d462
to
f8d3b8f
Compare
There was a problem hiding this comment.
@psybuzz FYI, in order to incorporate the changes, I rebased against master, fixed conflict, then pushed to tayo's branch.
Will merge when CI is happy.
|
Apologies for tardiness :). Thanks stephanwlee. Let me know if any other actions are necessary from my side. |
No description provided.