This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Replace .append loop with list comprehension #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lgeiger -- Can you resolve the conflicts here? Sorry for the delay in merging. |
This PR replaces loops that only append to a list with list comprehensions. This makes it more concise and arguably more readably. List comprehensions also are quite a bit faster than appending to a list. Toy example in Python 3.6: ```python In [1]: %%timeit ...: l = [] ...: for i in range(5000): ...: l.append(i) 375 µs ± 1.73 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each) In [2]: %%timeit ...: l = [i for i in range(5000)] 168 µs ± 1.08 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each) ```
lgeiger
force-pushed
the
list-comprehensions
branch
from
c523ef9 to
67fd40b
Compare
|
Rebased 👍 |
|
Thanks @lgeiger ! |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Mar 1, 2019
PiperOrigin-RevId: 236388504
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
This PR replaces loops that only append to a list with list comprehensions. This makes it more concise and arguably more readably. List comprehensions also are quite a bit faster than appending to a list. Toy example in Python 3.6: ```python In [1]: %%timeit ...: l = [] ...: for i in range(5000): ...: l.append(i) 375 µs ± 1.73 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each) In [2]: %%timeit ...: l = [i for i in range(5000)] 168 µs ± 1.08 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each) ```
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
PiperOrigin-RevId: 236388504
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces loops that only append to a list with list comprehensions. This makes it more concise and (arguably) more readably.
List comprehensions also are quite a bit faster than appending to a list. Toy example in Python 3.6: