This repository was archived by the owner on Jul 7, 2023. It is now read-only.
add text CNN model for text classification problem #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks unittest failed with unrelated error, would appreciate any reviews or comments. |
lukaszkaiser
approved these changes
Dec 5, 2018
tensorflow-copybara
pushed a commit
that referenced
this pull request
Dec 5, 2018
PiperOrigin-RevId: 224227181
|
Thanks for the model, good to know it can get reasonable results :). |
theorm
added a commit
to theorm/tensor2tensor
that referenced
this pull request
Dec 7, 2018
* master: New mesh_tensorflow transformer now handles encoder-decoder models and beam search. Fix bug in variable stacking code (operations in while loops did not get their inputs redirected) Fix datatype bug in simd_mesh_impl.py Minor cleanup. Moving one gym related function into its own file and added test. Unify naming across gym's method and ours and add "rl_env_" to the hparam, to give the hint where this gets used. internal merge of PR tensorflow#1277 Temperature (tensorflow#1277) internal merge of PR tensorflow#1271 add text CNN model for text classification problem (tensorflow#1271) Have a few shards for en-ro translation.
|
Hi, I'm trying to play with @ybbaigo would you like to do it? If not, I can do it for you. |
|
Sure, thanks for pointing out, I just added it with PR #1421 , please help review @afrozenator @lukaszkaiser BTW, Please feel free to let me know if you have any other problem about text_cnn model in the future. @heytitle |
|
@ybbaigo you're welcome. By the way, do you happen to have benchmarks for other problems, such as |
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
PiperOrigin-RevId: 224227181
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add textCNN model for text classification problem.