This repository was archived by the owner on Apr 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 149
[WIP]: Exploring removing <Float>
everywhere.
#465
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
20e4759
[WIP]: Exploring removing `<Float>` everywhere.
saeta 91bdc06
Fix build issues and clean up a bit.
saeta ff3582c
Clean up tinkercruft now that the builds are a bit more reliable.
saeta aa895a6
Have `TypedModule` refine `Module` instead of `Layer` to make more fl…
saeta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright 2019 The TensorFlow Authors. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
import TensorFlow | ||
|
||
/// A model composed of a variety of layers all using the same scalar type. | ||
public protocol TypedModule: Module { | ||
associatedtype Scalar: TensorFlowScalar | ||
|
||
typealias Tensor = TensorFlow.Tensor<Scalar> // For some reason, this doesn't work! | ||
typealias TensorF = TensorFlow.Tensor<Float> | ||
typealias TTensor = TensorFlow.Tensor | ||
} | ||
|
||
public extension TypedModule where Scalar: TensorFlowFloatingPoint { | ||
typealias Conv2D = TensorFlow.Conv2D<Scalar> | ||
typealias AvgPool2D = TensorFlow.AvgPool2D<Scalar> | ||
typealias MaxPool2D = TensorFlow.MaxPool2D<Scalar> | ||
typealias Flatten = TensorFlow.Flatten<Scalar> | ||
typealias Dense = TensorFlow.Dense<Scalar> | ||
typealias Embedding = TensorFlow.Embedding<Scalar> | ||
} | ||
|
||
/// A model composed of a variety of layers, where each one is parameterized | ||
/// by `Float`. | ||
public protocol FloatModel: TypedModule, Layer where Scalar == Float {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks way cleaner without noisy
<Float>
everywhere.