Fix various rustc and clippy warnings. #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcrume
requested changes
Mar 3, 2017
src/lib.rs
Outdated
| @@ -343,6 +343,7 @@ c_enum!("Type of a single tensor element.", TF_DataType, DataType { | |||
| /// 16-bit floating point. | |||
| value Half = 19, | |||
|
|
|||
| /// Tensorflow Resource (name, container, device,...) | |||
There was a problem hiding this comment.
'f' in TensorFlow needs to be capitalized.
src/lib.rs
Outdated
| pub fn version() -> std::result::Result<String, Utf8Error> { | ||
| unsafe { CStr::from_ptr(tf::TF_Version()).to_str().map(|s| s.to_string()) } | ||
| } | ||
|
|
||
| //////////////////////// | ||
|
|
||
| #[deprecated(note="Use Shape instead.")] | ||
| type TensorShape = Shape; |
There was a problem hiding this comment.
This was a bug and should have been public, which I fixed. Please cancel this deletion.
This changeset fixes various rustc and clippy warnings. Note that it also gets rid of some type aliases which have been private and are unused in the library (and since they are private they can't be used from outside anyways).
|
@adamcrume updated and rebased! |
|
Thanks! |
ramon-garcia
pushed a commit
to ramon-garcia/tensorflow-rust
that referenced
this pull request
May 20, 2023
* Displays formatted grid as per tensorflow#62 * update usage help * update readme for tensorflow#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes various rustc and clippy warnings. Note
that it also gets rid of some type aliases which have been
private and are unused in the library (and since they are
private they can't be used from outside anyways).