Update README.md#104
Conversation
-Update details -Made explicit HTTPS calls -Added a link to Homebrew
| tap that does essentially the same. | ||
| **macOS Note**: Via [Homebrew](https://brew.sh/) in process which, you can just run | ||
| `brew install libtensorflow`. | ||
|
|
There was a problem hiding this comment.
We might also want to revisit the Usage section where it is mentioned that TF is built during the crate's build process.
I believe the default now is to download a pre-built (basic CPU only) library instead of full compilation. See https://github.com/tensorflow/rust/blob/f204b39/tensorflow-sys/build.rs#L44-L52.
There was a problem hiding this comment.
How would you rewrite that section? I am unsure what to particularly add or remove.
There was a problem hiding this comment.
The paragraph's second sentence starts with Since TensorFlow is built during this process... but this sentence is now wrong (after PR #65).
The tensorflow-sys crate's build.rs will either download a pre-built binary (the default) or compile TF if forced to by an environment variable).
The README paragraph could be adapted to mention this.
There was a problem hiding this comment.
Does it seem good to you now?
README.md
Outdated
|
|
||
| * [Documentation](https://tensorflow.github.io/rust/tensorflow/) | ||
| * [TensorFlow website](http://tensorflow.org) | ||
| * [TensorFlow website](https://tensorflow.org) |
There was a problem hiding this comment.
This should be https://www.tensorflow.org because of tensorflow/tensorflow#12496.
There was a problem hiding this comment.
How do you know that the certificate expired on June 29?
There was a problem hiding this comment.
It depends on your browser, but in Firefox, I get a error page about the connection not being secure. I can then click on Advanced, and it displays the certificate's expiration date.
Add www
Add www
Remove unnecessary words
Update usage
adamcrume
left a comment
adamcrume
left a comment
There was a problem hiding this comment.
Looks good, but I'll give @nbigaouette-eai a chance to respond before I merge it.
|
Thanks! |
3 participants
-Update details
-Made explicit HTTPS calls
-Added a link to Homebrew