Skip to content

Conversation

@matthewfeickert
Copy link
Contributor

Resolves #1723

  • Add requires-python metadata through the addition of setuptools's python_requires in setup.py.

  • The addition of requires-python is to provide guards to keep older CPython versions from installing releases that could contain unrunnable code.

* Add requires-python metadata through the addition of setuptools's
  python_requires in setup.py.
   - c.f. https://peps.python.org/pep-0621/#requires-python

* The addition of requires-python is to provide guards to keep older
  CPython versions from installing releases that could contain
  unrunnable code.
@matthewfeickert
Copy link
Contributor Author

This is ready for review.

@copybara-service copybara-service bot merged commit 74eb27c into tensorflow:main May 16, 2023
@matthewfeickert matthewfeickert deleted the build/add-requires-python-metadata branch May 16, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lack of requires-python causes tfp v0.20.0 to break all Python 3.7 and older

1 participant