-
Notifications
You must be signed in to change notification settings - Fork 45.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity box coder, similarity calculator, target assigner #8962
Merged
tf-models-copybara-bot
merged 48 commits into
tensorflow:master
from
kmindspark:detr-push-3
Sep 15, 2020
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
0006ba7
target assigner mods
kmindspark c99e578
progress on pr
kmindspark c594cec
pr
kmindspark 7359586
Merge remote-tracking branch 'upstream/master' into detr-push-3
kmindspark 9bd3fe6
save progress
kmindspark ceb406b
ready pr
kmindspark c95500c
updates
kmindspark 4753d6e
Merge remote-tracking branch 'upstream/master' into detr-push-3
kmindspark 55db4ad
fix
kmindspark 70cb851
fix
kmindspark 322d444
minor style elements
kmindspark ba65cc7
fix tests
kmindspark 7b165eb
fix tests
kmindspark 3564e7c
fix
kmindspark a679728
fix
kmindspark 8948ba3
fix file
kmindspark 5f71a45
fix
kmindspark 7723b20
fix pr
kmindspark 980d176
fix
kmindspark dabfc27
fix
kmindspark f0bc684
fix this pr
kmindspark 4022aae
self code-review to clean up
kmindspark 22b5b0c
self code-review to clean up
kmindspark 245e9d1
add detr box coder test
kmindspark d31aba8
using already pushed files
kmindspark 356c98b
Merge remote-tracking branch 'upstream/master' into detr-push-3
kmindspark 824b70f
region similarity calculator mod
kmindspark c8cd7d1
progress on model lib
kmindspark 43eaeb0
remove detr lib
kmindspark 98516e5
small fix
kmindspark 4f7965f
remove detr lib
kmindspark e0b082e
fix documentation for box coder
kmindspark ab96cb3
separate out DETR
kmindspark 8e77b75
remove box coders
kmindspark 3d757d5
add line
kmindspark 4f135c7
compress target assigner
kmindspark d54c86d
make suggested fixes to target assigner and similarity calculator
kmindspark e09e056
target assigner and similarity calculator fixes
kmindspark 8f5ed2d
fixes to simplify
kmindspark 656ec2a
fixes to simplify
kmindspark 9d4b102
clean target assigner
kmindspark 323ea89
remove detr building
kmindspark a6f36d2
work on cleaning up further
kmindspark 111c9d3
target assigner test
kmindspark de3a34b
fix issues with target assigner for pr
kmindspark e350c59
fix num classes
kmindspark 1ed7ef3
fix naming
kmindspark 0bc599e
flip around similarity calculation
kmindspark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still a bit worried that we are carrying around a lot of legacy code for the DETR Target Assigner. Can you take a look at https://github.com/facebookresearch/detr/blob/master/models/matcher.py and see if we can do something similiar ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file just does the matching. Do you mean the fact that we do similarity calculation separately from the target assigner?