Skip to content
This repository was archived by the owner on Sep 27, 2024. It is now read-only.

Conversation

@codesue
Copy link
Contributor

@codesue codesue commented May 20, 2023

What does this pull request do?

Removes the docs extra introduced in #275 since it breaks the release build.

ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         Invalid value for requires_dist. Error: Can't have direct dependency:  
         "tensorflow-docs @ git+https://github.com/tensorflow/docs ; extra ==   
         'docs'"     

How did you test this change?

pytest model_card_toolkit

How did you document this change?

n/a

Before submitting

Before submitting a pull request, please be sure to do the following:

  • Read the How to Contribute guide if this is your first contribution.
  • Open an issue or discussion topic to discuss this change.
  • Write new tests if applicable.
  • Update documentation if applicable.

@codesue codesue marked this pull request as ready for review May 20, 2023 21:44
def make_required_extra_packages() -> Dict[str, List[str]]:
"""Returns the dict of required extra packages."""
return {
'docs': make_extra_packages_docs(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this break the TF website generation? Not sure how that is being generated...

Copy link
Contributor Author

@codesue codesue May 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, tensorflow_docs was never listed as a dependency. Here are the dependencies from 1.3: https://github.com/tensorflow/model-card-toolkit/blob/v1.3.0/setup.py#LL31-L42. It's needed to build the docs locally with python tools/build_api_docs.py.

I'm not sure exactly how the docs are being generated for the website yet, e.g. whether internal or tied to a TensorFlow release, but I'm following up on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the docs are built internally at Google in a manual process.

@codesue codesue merged commit c520a26 into tensorflow:main May 21, 2023
@codesue codesue deleted the codesue/fix-release branch May 21, 2023 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants