Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
winne42
force-pushed
the
feature/add-TBoolTest
branch
from
966fb69 to
0e67a8b
Compare
fixed |
Craigacp
left a comment
Craigacp
left a comment
There was a problem hiding this comment.
Thanks, I left a few comments with small changes.
| @@ -0,0 +1,142 @@ | |||
| package org.tensorflow.types; | |||
There was a problem hiding this comment.
Please add the same copyright statement as the other tests.
| import org.tensorflow.op.math.LogicalNot; | ||
| import org.tensorflow.op.math.LogicalOr; | ||
|
|
||
| class TBoolTest { |
There was a problem hiding this comment.
This should be public to match the rest of the tests.
There was a problem hiding this comment.
I changed this (in a separate commit) - but note that this is considered a code smell by SonarQube, cf. https://next.sonarqube.com/sonarqube/coding_rules?open=java%3AS5786&rule_key=java%3AS5786 or https://rules.sonarsource.com/java/quickfix/RSPEC-5786
There was a problem hiding this comment.
I think SonarQube is being a little nitpicky there, and if we're going to change that we'd do it everywhere in a separate PR.
| .scalars() | ||
| .forEach(scalar -> assertEquals(false, scalar.getObject())); | ||
|
|
||
| // Calculate x AND y and validate the result |
There was a problem hiding this comment.
This should be OR not AND.
winne42
force-pushed
the
feature/add-TBoolTest
branch
from
6851a69 to
b87bfb2
Compare
|
Thanks @winne42 , there are some formatting issues reported by the CI/CD, can you please check? |
|
@karllessard sorry about that, I ran spotless:apply, hope it works now |
|
Thanks! |
4 participants
List.copyOf()can be used