Added .bazelversion to be consitent with the TF build process #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a note to |
karllessard
requested changes
Jun 17, 2021
CONTRIBUTING.md
Outdated
| @@ -44,6 +44,11 @@ configuration script (`./configure`), and copy the resulting | |||
| `.tf_configure.bazelrc` to `tensorflow-core-api`. This overrides the default options, and you can add to it manually (i.e. adding `build --copt="-g"` | |||
| to build with debugging info). | |||
|
|
|||
| The `tensorflow-core/tensorflow-core-api/.bazelversion` file must be kept in sync with `@org_tensorflow/.bazel_version`. | |||
| This allows using [Bazelisk](https://github.com/bazelbuild/bazelisk) which runs the bazel version given in .bazelversion instead of having to | |||
| physically reinstall a specifc `bazel` version each time the TensorFlow version changes. | |||
There was a problem hiding this comment.
"specifc" -> "specific"
CONTRIBUTING.md
Outdated
| @@ -44,6 +44,11 @@ configuration script (`./configure`), and copy the resulting | |||
| `.tf_configure.bazelrc` to `tensorflow-core-api`. This overrides the default options, and you can add to it manually (i.e. adding `build --copt="-g"` | |||
| to build with debugging info). | |||
|
|
|||
| The `tensorflow-core/tensorflow-core-api/.bazelversion` file must be kept in sync with `@org_tensorflow/.bazel_version`. | |||
There was a problem hiding this comment.
must be (two spaces) -> "must be"
karllessard
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
.bazelversiontotensorflow-core-apito be consistent with the TF Build process defined at Build from source. The TF build source recommends using Bazelisk which runs thebazelversion given in.bazelversion. Otherwise, the exact matchingbazelversion will need to be installed for each TF version.This file needs to be kept in sync with
@org_tensorflow/.bazel_version.