Changing quick build over to use actions/setup-java and Java 8 #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
changed the title
Collaborator
|
Multiple thanks @Craigacp ! |
karllessard
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/setup-java is the preferred way of specifying the JDK in a Github action. This PR changes the quick-build ci pipeline over to use setup-java and specifies Java 8 as the build JDK. It doesn't modify any of the long builds or the packaging pipeline, we can experiment with introducing it there later.
This fixes our javadoc build failures. The javadoc still has errors in, but at least it doesn't fail the whole CI and ignore test results.