This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Fix bug when slicing on a segmented dimension#2
Merged
karllessard merged 1 commit intotensorflow:mainfrom Jul 27, 2021
Merged
Conversation
Craigacp
reviewed
Jul 27, 2021
| } | ||
| Dimension[] newDimensions = Arrays.copyOfRange(dimensions, dimensionStart, dimensions.length); | ||
| if (segmentationIdx > dimensionStart) { | ||
| if (segmentationIdx >= dimensionStart) { |
Contributor
There was a problem hiding this comment.
So the bug was repeated slicing from the start of the ndarray?
Contributor
|
I tested it with my |
JimClarke5
approved these changes
Jul 27, 2021
Contributor
JimClarke5
left a comment
JimClarke5
left a comment
There was a problem hiding this comment.
This bug also appears in the dense version, both dense and sparse now work for me with this change.
Contributor
Author
|
Thanks @JimClarke5 and @Craigacp ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug found by @JimClarke5 while working on the Sparse tensors. When slicing on a dimension that was segmented (i.e. which elements are no more sequential due to a previous slice), we were losing track of that information.