Skip to content

Bump abseil-cpp to 6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

yongtang
Copy link
Member

This PR bumps abseil-cpp to 6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c
to fix the build issue.

See related changes in tensorflow/tensorflow@1c9eeb9

Signed-off-by: Yong Tang yong.tang.github@outlook.com

This PR bumps abseil-cpp to 6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c
to fix the build issue.

See related changes in tensorflow/tensorflow/commit/1c9eeb9eaa1b712d71fc29bcc9054c25c7236fa2

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@oliverhu
Copy link
Contributor

thanks for fixing the build!

Copy link
Member

@kvignesh1420 kvignesh1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongtang this is unrelated to this CL but seems like the flaky centos7 action has been restored due to an improper rebase in #1283. Can you please remove that task as well in this PR?

- name: CentOS 7
run: |
if [[ "${EVENT_NAME}" == "push" && "${REPO_NAME}" == "tensorflow/io" ]]; then
printf '%s\n' "${GCP_CREDS}" >service_account_creds.json
export BAZEL_OPTIMIZATION="--remote_cache=https://storage.googleapis.com/tensorflow-sigs-io --remote_upload_local_results=true --google_credentials=service_account_creds.json"
else
export BAZEL_OPTIMIZATION="--remote_cache=https://storage.googleapis.com/tensorflow-sigs-io --remote_upload_local_results=false"
fi
set -x -e
bash -x -e .github/workflows/build.space.sh
python3 .github/workflows/build.instruction.py docs/development.md "##### CentOS 7" > source.sh
cat source.sh
docker run -i --rm -v $PWD:/v -w /v --net=host \
-e BAZEL_OPTIMIZATION="${BAZEL_OPTIMIZATION}" \
centos:7 bash -x -e source.sh

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

Thanks @kvignesh1420 . PR has been updated. Please take a look

Copy link
Member

@kvignesh1420 kvignesh1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yongtang

@kvignesh1420 kvignesh1420 merged commit 9d32874 into tensorflow:master Mar 23, 2021
@yongtang yongtang deleted the bump=abseil-cpp branch March 23, 2021 05:05
michaelbanfield pushed a commit to michaelbanfield/io that referenced this pull request Mar 30, 2021
…ow#1336)

* Bump abseil-cpp to 6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c

This PR bumps abseil-cpp to 6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c
to fix the build issue.

See related changes in tensorflow/tensorflow/commit/1c9eeb9eaa1b712d71fc29bcc9054c25c7236fa2

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Remove flaky CentOS 7 build

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants