-
Notifications
You must be signed in to change notification settings - Fork 301
Initial commit of s3 modular file system plugin (credit @vnvo2409) #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Thank you so much for this PR @yongtang !
I think it's quite hard to run this test because it depends on many components of TF core. I think we could port the tests to python, it should be easier, WDYT ? In addition, I saw you have bumped the version of |
Yes I think having tests in python would be a lot easier to maintain.
I think that should be possible. I will take a look, likely in a follow up PR to bump the AWS SDK to 1.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yongtang since we directly porting from TensorFlow, we can merge this as of now. We can make the necessary modifications in different PR's.(if needed)
Let's merge this PR. Thanks @vnvo2409 @kvignesh1420 ! |
Thank you @yongtang ! I will have some spare time in December and I will get more involved in the migration process. |
Thanks @vnvo2409! I updated the issue in #1183 (comment) with items and follow ups (e.g., update AWS SDK, enable logging, etc). |
…ensorflow#1191) * Initial commit of s3 modular file system plugin (credit vnvo2409) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Disable use_multi_part_download for now, and several fixes Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Initial commit of s3 modular file system plugin (credit @vnvo2409)
This PR is an initial commit to move S3 modular file system plugin to tensorflow-io. @vnvo2409 is the author and this PR is just a mechanic move of code.
There are a several tiny changes
s3e://
. This is to avoid the collision with TF'ss3://
. Once we have done all the testing we can remove the TF's registration ofs3://
and change registration in tensorflow-io froms3e://
tos3://
.Signed-off-by: Yong Tang yong.tang.github@outlook.com