Skip to content

Update Package Version Numbers #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 11, 2020
Merged

Conversation

jcmartin
Copy link
Contributor

This pull request simply updates the package version numbers following the Haskell Package Version Policy: https://pvp.haskell.org/ .

If we agree on the version numbers, the next pull request will be for an update haddock documentation, which is presently out of date.

Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix up the conflict marker?

@@ -17,7 +17,11 @@ library
exposed-modules: TensorFlow.OpGen.ParsedOp
, TensorFlow.OpGen
build-depends: proto-lens == 0.7.*
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

, tensorflow-ops == 0.2.*
, tensorflow-proto == 0.2.*
, tensorflow-records-conduit == 0.1.*
, tensorflow >= 0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we tested the combinations, so it's probably safer to just change all the versions together and keep them at the same 0.3 value. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the haskell files (*.hs) were not altered when I patched for TF 2.3, it is safe to say that they are compatible with both the old and new version. However, the proto-lens dependency update (in order to move to a newer version of LTS) did cause a problem in terms of dependency conflict.

Doing this ensures that if someone wanted to patch an older version of the libraries with the new proto-lens package, they would be able to. However, I will admit that this is a pretty fringe case.

Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably inconsequential either way. I'll merge as is.

@jcmartin jcmartin requested a review from blackgnezdo November 10, 2020 20:17
@blackgnezdo blackgnezdo merged commit 4d9d315 into tensorflow:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants