Skip to content

Added support for tanh activation function #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

rikvdkleij
Copy link
Contributor

The CLA is signed by the manager of my company, Active Group GmbH. Please let me know if more info is needed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@rikvdkleij
Copy link
Contributor Author

My company signed it!

The email of the git commits is rik.van.der.kleij@active.group@de which is a member of the active-group-google-contributors@googlegroups.com

@fkm3
Copy link
Contributor

fkm3 commented Nov 8, 2018

Thanks for the contribution!

Did your company just sign the CLA? If so, we might need to wait a day or two for it to get processed. If not, I can ask someone why it isn't recognizing you.

@rikvdkleij
Copy link
Contributor Author

@fkm3 Yes, it was just signed a few hours ago.

@fkm3
Copy link
Contributor

fkm3 commented Nov 8, 2018

OK. The code looks good to me. I'll check in tomorrow to see if the CLA stuff is ready on our side.

@rikvdkleij
Copy link
Contributor Author

@fkm3 Any news about the CLA stuff?

@fkm3
Copy link
Contributor

fkm3 commented Nov 12, 2018

I think it went through now. Can you reply with "I signed it!" to make the bot re-run the check? Thanks!

@rikvdkleij
Copy link
Contributor Author

I signed it!

@fkm3
Copy link
Contributor

fkm3 commented Nov 13, 2018

Now it says "CLAs are signed, but unable to verify author consent". Is the email used in the commit attached to your GitHub account?

Sorry that this is a pain...

@rikvdkleij
Copy link
Contributor Author

No, the email of the commits is my email.The CLA is signed by the manager of Active Group GmbH. He is the owner of active-group-google-contributors@googlegroups.com. My email is a member of that Google group.

@fkm3
Copy link
Contributor

fkm3 commented Nov 13, 2018

I think you need to add your @active-group.de email to your @rikvdkleij github account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/
(it doesn't need to be the primary, just verified)

@rikvdkleij
Copy link
Contributor Author

@fkm3 Have done that. Thanks!

I will trigger the Google bot again.

@googlebot
Copy link

CLAs look good, thanks!

@rikvdkleij
Copy link
Contributor Author

I signed it!

@fkm3 fkm3 merged commit 9150150 into tensorflow:master Nov 14, 2018
@fkm3
Copy link
Contributor

fkm3 commented Nov 14, 2018

Success! Thanks for sticking with me.

@rikvdkleij
Copy link
Contributor Author

Thanks for guiding me through the CLA stuff! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants