Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added class_weight for imbalanced datasets #307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pdubz-sudo
Copy link

  • added class_weight to create and train method in image_classifier.py
  • added class_weight to train_model method in train_image_classifier.py
    All this was done so that the class_weight can be added to the model.fit() because Keras Models already have this as an argument.

I was not able to actually test if this works because I can't build from source when I tried from the readme instructions for model maker (I'm not sure why I can't build). So, these are the changes I think will work. Keras Model already has class_weight as an argument in the .fit() so I just tried to change the code so that a class_weight can be added from the .create() of the model_maker for image classification.

- added class_weight to create and train method in image_classifier.py
- added class_weight to train_model method in train_image_classifier.py
All this was done so that the class_weight can be added to the model.fit() because Keras Models already have this as an argument.

I was not able to actually test if this works because I can't build from source when I tried from the readme instructions for model maker (I'm not sure why I can't build). So, these are the changes I think will work. Keras Model already has class_weight as an argument in the .fit() so I just tried to change the code so that a class_weight can be added from the .create() of the model_maker for image classification.
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Apr 23, 2021
@google-cla
Copy link

google-cla bot commented Apr 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA has not been signed label Apr 23, 2021
@pdubz-sudo
Copy link
Author

pdubz-sudo commented Apr 23, 2021

I made this feature request and am hoping this PR solves it tensorflow/tensorflow#48703

@pdubz-sudo
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Apr 23, 2021
Removed None because it was over-writing the class weight which already coming from another function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant