This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Add alternate method of parsing to enable orbit benchmarks #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for benchmarks to be specified with the format <benchmark_class>:<benchmark_method_name>.
There should only ever be one argument to --perfzero_constructor_args (as all the args are grouped together in a JSON-serialized dict).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orbit benchmarks refers to those under this class: https://github.com/tensorflow/models/blob/benchmark/official/benchmark/base_benchmark.py#L62
The new target format will be 'official.benchmark.base_benchmark.BaseBenchmark:benchmark__{benchmark method name}'
This is needed because the benchmark method name may contain the '.' char (e.g. https://github.com/tensorflow/models/blob/benchmark/official/benchmark/benchmark_definitions.py#L20), so the original parsing doesn't work; now we use ':' as the separator.