Skip to content

Implements YogiOptimizer #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 10, 2019
Merged

Implements YogiOptimizer #745

merged 22 commits into from
Dec 10, 2019

Conversation

manzilz
Copy link
Contributor

@manzilz manzilz commented Dec 6, 2019

Implement Yogi optimizer in paper Adaptive Methods for Nonconvex Optimization as a tf.keras.optimizers.Optimizer

@jkr26
Copy link

jkr26 commented Dec 7, 2019

+1 to this PR!!

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manzilz, thanks for the contribution! Could you run make code-format to format codes?

@manzilz
Copy link
Contributor Author

manzilz commented Dec 8, 2019

@WindQAQ Finished code formatting. PTAL

@manzilz
Copy link
Contributor Author

manzilz commented Dec 8, 2019

Fixed a small error.

@avinava-o
Copy link

+1 for this PR!

@manzilz
Copy link
Contributor Author

manzilz commented Dec 10, 2019

Any update @WindQAQ @facaiy @Squadrick ?

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@WindQAQ WindQAQ merged commit 604a70d into tensorflow:master Dec 10, 2019
@relaxation82
Copy link

It seems that the Yogi optimiser was released as part of tensorflow-addons-0.7.0, but I am unable to find any documentation about it. In the case I was just blind, could someone provide a link to a page with the documentation, or in case it is actually missing for the documentation, could you provide a short example describing how it can be used?

@seanpmorgan
Copy link
Member

It seems that the Yogi optimiser was released as part of tensorflow-addons-0.7.0, but I am unable to find any documentation about it. In the case I was just blind, could someone provide a link to a page with the documentation, or in case it is actually missing for the documentation, could you provide a short example describing how it can be used?

@relaxation82 thank you very much for this callout. Seems the import got missed and thus the API docs were not generated.

I've submitted a PR to fix this (#875) and we will likely do a patch release in the next couple of weeks. In the mean time it can still be used on 0.7.0 with:

from tensorflow_addons.optimizers.yogi import Yogi

The documentation will be whats present in the doc strings of the module:
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/optimizers/yogi.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants