-
Notifications
You must be signed in to change notification settings - Fork 615
Implements YogiOptimizer #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1 to this PR!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @manzilz, thanks for the contribution! Could you run make code-format
to format codes?
@WindQAQ Finished code formatting. PTAL |
Fixed a small error. |
+1 for this PR! |
Any update @WindQAQ @facaiy @Squadrick ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR!
It seems that the Yogi optimiser was released as part of tensorflow-addons-0.7.0, but I am unable to find any documentation about it. In the case I was just blind, could someone provide a link to a page with the documentation, or in case it is actually missing for the documentation, could you provide a short example describing how it can be used? |
@relaxation82 thank you very much for this callout. Seems the import got missed and thus the API docs were not generated. I've submitted a PR to fix this (#875) and we will likely do a patch release in the next couple of weeks. In the mean time it can still be used on 0.7.0 with:
The documentation will be whats present in the doc strings of the module: |
Implement Yogi optimizer in paper Adaptive Methods for Nonconvex Optimization as a tf.keras.optimizers.Optimizer