Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build against 2.14.0 #2850

Merged
merged 37 commits into from
Oct 17, 2023
Merged

Build against 2.14.0 #2850

merged 37 commits into from
Oct 17, 2023

Conversation

seanpmorgan
Copy link
Member

No description provided.

@boring-cyborg boring-cyborg bot added the github label Sep 19, 2023
@seanpmorgan
Copy link
Member Author

seanpmorgan commented Sep 19, 2023 •
edited
Loading

Need to update as:
tensorflow/tensorflow@66b9b9b#diff-117cd8a79150901519d641f6ffa5d426c184d2dc2a40b102050972854da00d84

Same issue reported in #2849

@trevor-m
Copy link
Contributor

Hi @seanpmorgan, TF 2.14 has been released. Any luck with the TF addons build?

bhack
bhack reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bhack bhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to 2.14.0

@bhack bhack changed the title [WIP] Build against 2.14.0rc1 [WIP] Build against 2.14.0 Oct 10, 2023
bhack
bhack reviewed Oct 11, 2023
View reviewed changes
WORKSPACE Outdated
],
)
# TODO: please double check what it is really required or not in this section
Copy link
Contributor

@bhack bhack Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanpmorgan This was commited by the bot/proxy GitHub account in the upstream TF WORKSPACE. Can you ping SIG-Build team to know who is the owner of that new section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongtang is handling the same at tensorflow/io#1831

@seanpmorgan seanpmorgan changed the title [WIP] Build against 2.14.0 Build against 2.14.0 Oct 16, 2023
@seanpmorgan
Copy link
Member Author

Same thing we did against TF2.13 build. Given that we have about ~3 more releases left , I think we can just keep the lights on and not take the bazel workspace dependency on TF2.14 with hermetic python. The custom ops are compiled against TF2.14 as is written to .bazelrc

Open to a PR to clean up the build env (will also try to clean it up if I can get some free cycles). tensorflow/build is still publishing a container for each python version so I don't see a huge need to adopt the new build strategy.

bhack
bhack approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@bhack bhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I hope that it will not be mandatory to upgrade the workspace sooner or later.

@seanpmorgan seanpmorgan merged commit 52427df into tensorflow:master Oct 17, 2023
48 checks passed
@seanpmorgan seanpmorgan deleted the build-tf214 branch October 17, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhack bhack bhack approved these changes

@AakashKumarNain AakashKumarNain Awaiting requested review from AakashKumarNain AakashKumarNain is a code owner

@WindQAQ WindQAQ Awaiting requested review from WindQAQ WindQAQ is a code owner

Assignees
No one assigned
Labels
activations github metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanpmorgan @trevor-m @bhack @fsx950223