-
Notifications
You must be signed in to change notification settings - Fork 616
rsquare metric #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsquare metric #283
Conversation
I have MAC and facing issue in building addons. So, I tested code in colab. Please let me know what will be my next steps. To do as far as I know will be to add test for the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSaishruthi A few changes. Also, you need to update the following: __init__.py
, README.md
and create tests.
Thanks @Squadrick |
@Squadrick |
Added test cases |
@SSaishruthi You need to add this to run the test cases in graph and eager mode. |
@Squadrick I have added test scripts in PR. Do you mean to add this line? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the following files: __init__.py
, BUILD
and README.md
Hi @Squadrick |
@SSaishruthi I'm gonna trigger the pre-submit tests, you might have to make a few more changes after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, your code fails the sanity check. Use make code-format
like mentioned here to format code.
Hi @Squadrick Updated code as per the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSaishruthi Looks good, thanks for the contribution. I'm gonna trigger the tests again.
@SSaishruthi Your |
@Squadrick |
@Squadrick Thanks for the review and helping me through this. |
This PR contains a script for adding R-Square metric.
Sample colab: https://colab.research.google.com/drive/1Qh3zYhpoB_Ln6O2d6YSBqviYsuw0W9VS