Skip to content

rsquare metric #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 17, 2019
Merged

rsquare metric #283

merged 10 commits into from
Jun 17, 2019

Conversation

SSaishruthi
Copy link
Contributor

This PR contains a script for adding R-Square metric.

Sample colab: https://colab.research.google.com/drive/1Qh3zYhpoB_Ln6O2d6YSBqviYsuw0W9VS

@SSaishruthi SSaishruthi requested a review from a team as a code owner June 12, 2019 18:11
@SSaishruthi
Copy link
Contributor Author

I have MAC and facing issue in building addons. So, I tested code in colab.

Please let me know what will be my next steps. To do as far as I know will be to add test for the same.

Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSaishruthi A few changes. Also, you need to update the following: __init__.py, README.md and create tests.

@SSaishruthi
Copy link
Contributor Author

Thanks @Squadrick
Will update soon

@SSaishruthi
Copy link
Contributor Author

SSaishruthi commented Jun 13, 2019

@Squadrick
Updated changes. I will work on test cases.

@SSaishruthi
Copy link
Contributor Author

Added test cases

@Squadrick
Copy link
Member

Squadrick commented Jun 14, 2019

@SSaishruthi You need to add this to run the test cases in graph and eager mode.

@SSaishruthi
Copy link
Contributor Author

SSaishruthi commented Jun 14, 2019

@Squadrick I have added test scripts in PR. Do you mean to add this line?

Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the following files: __init__.py, BUILD and README.md

@SSaishruthi
Copy link
Contributor Author

Hi @Squadrick
Updated scripts. Please let me know for any changes.
Colab: https://colab.research.google.com/drive/1Qh3zYhpoB_Ln6O2d6YSBqviYsuw0W9VS

@Squadrick
Copy link
Member

@SSaishruthi I'm gonna trigger the pre-submit tests, you might have to make a few more changes after that.

Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your code fails the sanity check. Use make code-format like mentioned here to format code.

@SSaishruthi
Copy link
Contributor Author

Hi @Squadrick

Updated code as per the comments.

Squadrick
Squadrick previously approved these changes Jun 17, 2019
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSaishruthi Looks good, thanks for the contribution. I'm gonna trigger the tests again.

@Squadrick
Copy link
Member

@SSaishruthi Your BUILD file formatting is incorrect, once you fix that the tests should pass.

@SSaishruthi
Copy link
Contributor Author

@Squadrick
I think I have missed , in BUILD. Updated now. Can you please trigger the test?

@SSaishruthi
Copy link
Contributor Author

@Squadrick Thanks for the review and helping me through this.

@Squadrick Squadrick merged commit 25cf38e into tensorflow:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants