Skip to content

Remove subpackage maintainer concept #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Remove subpackage maintainer concept #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,5 @@
# TensorFlow Addons Codeowners

#####################################################################################
# Subpackage Owners

/tensorflow_addons/activations/ @facaiy @seanpmorgan
/tensorflow_addons/callbacks/ @shun-lin
/tensorflow_addons/image/ @windqaq @facaiy
/tensorflow_addons/layers/ @seanpmorgan @facaiy
/tensorflow_addons/losses/ @facaiy @windqaq
/tensorflow_addons/metrics/ @marload
/tensorflow_addons/optimizers/ @facaiy @windqaq
/tensorflow_addons/rnn/ @qlzh727
/tensorflow_addons/seq2seq/ @qlzh727 @guillaumekln
/tensorflow_addons/text/ @seanpmorgan @facaiy

/tensorflow_addons/custom_ops/image/ @windqaq @facaiy
/tensorflow_addons/custom_ops/seq2seq/ @qlzh727
/tensorflow_addons/custom_ops/text/ @seanpmorgan @facaiy

#####################################################################################
# Submodule Owners
# These will not always trigger a GitHub review because submodule owners do not
# always have write access. However, a bot will notify them of the needed review.
Expand Down
11 changes: 6 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,12 @@ tfa.options.TF_ADDONS_PY_OPS = True
This variable defaults to `True` on Windows and macOS, and `False` on Linux.

#### Proxy Maintainership
TensorFlow Addons has been designed to compartmentalize subpackages and submodules so
that they can be maintained by users who have expertise and a vested interest
in that component.
TensorFlow Addons has been designed to compartmentalize submodules so
that they can be maintained by community users who have expertise, and a vested
interest in that component. We heavily encourage users to submit sign up to maintain a
submodule by submitting your username to the [CODEOWNERS](.github/CODEOWNERS) file.

Subpackage maintainership will only be granted after substantial contribution
Full write access will only be granted after substantial contribution
has been made in order to limit the number of users with write permission.
Contributions can come in the form of issue closings, bug fixes, documentation,
new code, or optimizing existing code. Submodule maintainership can be granted
Expand All @@ -229,7 +230,7 @@ For more information see [the RFC](https://github.com/tensorflow/community/blob/
on this topic.

#### Periodic Evaluation of Subpackages
Given the nature of this repository, subpackages and submodules may become less
Given the nature of this repository, submodules may become less
and less useful to the community as time goes on. In order to keep the
repository sustainable, we'll be performing bi-annual reviews of our code to
ensure everything still belongs within the repo. Contributing factors to this
Expand Down