Skip to content

preprocessing refactor #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2020
Merged

preprocessing refactor #2040

merged 3 commits into from
Aug 3, 2020

Conversation

jlsneto
Copy link
Contributor

@jlsneto jlsneto commented Jul 25, 2020

Description

Please include a summary of the change and which issue is fixed.

  • added type hints
  • error handling
  • improves functions and documentation

Fixes # (issue)

Type of change

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

@jlsneto
preprocessing refactor
2afd2e4 
- added type hints
- error handling
- improves functions and documentation
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

@WindQAQ WindQAQ self-requested a review July 27, 2020 18:09
WindQAQ
WindQAQ reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlsneto Thanks for he contribution! Seems that the output cells are empty. Can you run the notebook on colab to make the cells output something? Thanks!

@jlsneto
Copy link
Contributor Author

jlsneto commented Jul 27, 2020

@jlsneto Thanks for he contribution! Seems that the output cells are empty. Can you run the notebook on colab to make the cells output something? Thanks!

sorry, habit of cleaning 😃

@WindQAQ
Copy link
Member

WindQAQ commented Jul 27, 2020

@jlsneto Thanks for he contribution! Seems that the output cells are empty. Can you run the notebook on colab to make the cells output something? Thanks!

sorry, habit of cleaning 😃

Sorry for the misleading information. The PR looks good to me, but let's hold on and wait for the response of #2044 (comment).

@WindQAQ WindQAQ self-requested a review August 3, 2020 01:15
WindQAQ
WindQAQ approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@WindQAQ WindQAQ merged commit ec04b01 into tensorflow:master Aug 3, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@jlsneto
preprocessing refactor (tensorflow#2040)
3e5af11 
* preprocessing refactor

- added type hints
- error handling
- improves functions and documentation

* make the cells output

* fixes and improves preprocess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindQAQ WindQAQ WindQAQ approved these changes

Assignees
No one assigned
Labels
cla: yes documentation tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlsneto @WindQAQ @googlebot