Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved test out of run_in_graph_and_eager_mode in maxout. #1434

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Moved test out of run_in_graph_and_eager_mode in maxout. #1434

merged 1 commit into from
Mar 27, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

See #1328

@boring-cyborg boring-cyborg bot added the layers label Mar 26, 2020
@bot-of-gabrieldemarmiesse
Copy link

@failure-to-thrive

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@AakashKumarNain AakashKumarNain merged commit 23a369e into tensorflow:master Mar 27, 2020
@gabrieldemarmiesse
Copy link
Member Author

Thanks for the review!

@failure-to-thrive
Copy link
Contributor

Too late, but looks like

from tensorflow_addons.utils import test_utils

is not required either...

@gabrieldemarmiesse
Copy link
Member Author

@failure-to-thrive it's used in the last test.

Generally flake8 catches unused imports in the CI :)

jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@gabrieldemarmiesse
Moved test out of run_in_graph_and_eager_mode in maxout. (tensorflow#…
ea30be0 
…1434)

See tensorflow#1328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AakashKumarNain AakashKumarNain AakashKumarNain approved these changes

@failure-to-thrive failure-to-thrive failure-to-thrive approved these changes

Assignees
No one assigned
Labels
cla: yes layers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrieldemarmiesse @bot-of-gabrieldemarmiesse @failure-to-thrive @AakashKumarNain @googlebot