Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test out of run_in_graph_and_eager_mode in sparsemax. #1406

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Move test out of run_in_graph_and_eager_mode in sparsemax. #1406

merged 1 commit into from
Mar 25, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

See #1328

@bot-of-gabrieldemarmiesse
Copy link

@AndreasMadsen

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

seanpmorgan
seanpmorgan approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit 5eb5ac3 into tensorflow:master Mar 25, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@gabrieldemarmiesse
Move test out of run_in_graph_and_eager_mode in sparsemax. (tensorflo…
dc95ea5 
…w#1406)

See tensorflow#1328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees
No one assigned
Labels
activations cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieldemarmiesse @bot-of-gabrieldemarmiesse @seanpmorgan @googlebot