Skip to content

[WIP] Should break in eager mode. #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] Should break in eager mode. #1289

wants to merge 3 commits into from

Conversation

gabrieldemarmiesse
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse commented Mar 11, 2020 •
edited
Loading

Do not merge. It's just a test. If all the tests are passing, we're not testing the eager mode.

@bot-of-gabrieldemarmiesse
Copy link

@AakashKumarNain @SSaishruthi

You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@gabrieldemarmiesse gabrieldemarmiesse mentioned this pull request Mar 11, 2020
Merged
@AakashKumarNain
Copy link
Member

If all the tests are passing, we're not testing the eager mode.

Sorry, I didn't get this. We aren't testing eager mode?

@gabrieldemarmiesse
Copy link
Member Author

It's work in progress. I'm trying to get rid of run_all_in_graph_and_eager_mode. At the same time, I noticed that we were not testing some functions in eager mode. This pull request should not be merged. It's just to prove that if a bug happens only in eager mode, we won't know about it.

@boring-cyborg boring-cyborg bot added the image label Mar 11, 2020
@seanpmorgan seanpmorgan changed the title Should break in eager mode. [WIP] Should break in eager mode. Mar 12, 2020
@seanpmorgan seanpmorgan added blocked Pending something elses completion and removed blocked Pending something elses completion labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AakashKumarNain AakashKumarNain Awaiting requested review from AakashKumarNain AakashKumarNain is a code owner

@WindQAQ WindQAQ Awaiting requested review from WindQAQ WindQAQ is a code owner

Assignees
No one assigned
Labels
cla: yes image layers losses metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrieldemarmiesse @bot-of-gabrieldemarmiesse @AakashKumarNain @googlebot @seanpmorgan